Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: unit test PoC for isTokenValid #6303

Merged
merged 17 commits into from
Jan 10, 2025
Merged

test: unit test PoC for isTokenValid #6303

merged 17 commits into from
Jan 10, 2025

Conversation

jannisvisser
Copy link
Contributor

@jannisvisser jannisvisser commented Dec 18, 2024 •
edited by azure-boards bot
Loading

AB#31601

Describe your changes

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

@jannisvisser jannisvisser changed the title WIP test: unit test PoC for isTokenValid Dec 18, 2024
@jannisvisser jannisvisser added the chore Something that does not affect the end user label Dec 18, 2024
@jannisvisser jannisvisser mentioned this pull request Dec 18, 2024
Closed
4 tasks
diderikvw
diderikvw requested changes Dec 20, 2024
View reviewed changes
@jannisvisser
Copy link
Contributor Author

jannisvisser commented Dec 20, 2024 •
edited
Loading

@diderikvw can be reviewed again

  • I processed all comments. Some are left open for you to resolve if approved.
  • Open point is the removal of the transfer() unit tests in favour of integration test.
  • And open point is to resolve all ##TODO's for which there's a separate task.

@jannisvisser jannisvisser force-pushed the test.unit-test-isTokenValid branch from e46d72f to efd4b9d Compare January 3, 2025 15:13
@jannisvisser jannisvisser mentioned this pull request Jan 10, 2025
Merged
4 tasks
diderikvw and others added 5 commits January 10, 2025 12:21
@diderikvw @jannisvisser
WIP
ae38c41 
Add simple test files

Turn of jest cache

Remove noCache for jest and rename e2e to integration tests

Add comments for unit testing SafaricomService

Add comments
@jannisvisser
test: test isTokenValid by moving it to helper service AB#31601
693814b
@jannisvisser
test: also unit test transfer method in api service AB#32289
c9ef9f6
@jannisvisser
chore: cleanup
91f6437
@jannisvisser
fix: test
7a43237
@jannisvisser jannisvisser force-pushed the test.unit-test-isTokenValid branch from efd4b9d to a1a8219 Compare January 10, 2025 11:22
@diderikvw
Unit testing isTokenValid clean-up (#6373)
10854e4 
* Clean up ## TODOs

* Resolve final ##TODOs
@jannisvisser jannisvisser enabled auto-merge (squash) January 10, 2025 14:39
@jannisvisser jannisvisser merged commit 422112e into main Jan 10, 2025
8 checks passed
@jannisvisser jannisvisser deleted the test.unit-test-isTokenValid branch January 10, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aberonni aberonni aberonni left review comments

@RubenGeo RubenGeo RubenGeo left review comments

@diderikvw diderikvw diderikvw approved these changes

Assignees
No one assigned
Labels
chore Something that does not affect the end user
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jannisvisser @aberonni @diderikvw @RubenGeo